re-export the interrupt attribute
#235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Before landing this, the RFC rust-embedded/cortex-m-rt#122 needs to be accepted. |
|
Pinging @whitequark as we'll want to re-spin tm4c12xx when this lands. |
bors bot
added a commit
to rust-embedded/cortex-m-rt
that referenced
this pull request
Oct 9, 2018
122: [RFC] `#[interrupt]` r=therealprof a=japaric this PR adds an `interrupt` attribute that's similar to the existing `exception` except that it's used to override device-specific interrupt handlers. The other big difference is that `cortex_m_rt::interrupt` can't be directly used; it must first be imported from a device crate, which re-exports `cortex_m_rt::interrupt`. This is required to check at compile time that the interrupt is valid for the target device. Safe `static mut` variables can be used with `#[interrupt]` handlers. The syntax is the same as `#[exception]`s. More background information can be found in #109. The companion svd2rust PR is rust-embedded/svd2rust#235 r? @rust-embedded/cortex-m Co-authored-by: Jorge Aparicio <[email protected]> Co-authored-by: Adam Greig <[email protected]>
|
Upstream cortex-m-rt v0.6.5 has landed with |
benkard
added a commit
to benkard/stm32f4xx-hal
that referenced
this pull request
Nov 7, 2018
This is necessary to support rust-embedded/svd2rust#235.
this is a breaking change because - it bumps the cortex-m-rt version requirement to v0.6.4 - it changes the behavior of the `<device>::interrupt` item. This item was a bang macro and now have become an attribute.
japaric
force-pushed
the
interrupt-attr
branch
from
2dab852 to
6954d60
Compare
|
Triage: this has been accepted by the cortex-m team and it's waiting for review. |
japaric
added
S-waiting-on-review
|
bors r=therealprof |
bors bot
added a commit
that referenced
this pull request
Nov 14, 2018
235: re-export the `interrupt` attribute r=therealprof a=japaric this is a breaking change because - it bumps the cortex-m-rt version requirement to v0.6.4 - it changes the behavior of the `<device>::interrupt` item. This item was a bang macro and now has become an attribute. Co-authored-by: Jorge Aparicio <[email protected]>
Build failed |
|
fixed the build error. re-r? @therealprof (or anyone else) |
therealprof
approved these changes
Nov 14, 2018
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 14, 2018
235: re-export the `interrupt` attribute r=therealprof a=japaric this is a breaking change because - it bumps the cortex-m-rt version requirement to v0.6.4 - it changes the behavior of the `<device>::interrupt` item. This item was a bang macro and now has become an attribute. Co-authored-by: Jorge Aparicio <[email protected]>
Build succeeded |
adamgreig
added a commit
to rust-embedded/cortex-m
that referenced
this pull request
Jan 12, 2022
122: [RFC] `#[interrupt]` r=therealprof a=japaric this PR adds an `interrupt` attribute that's similar to the existing `exception` except that it's used to override device-specific interrupt handlers. The other big difference is that `cortex_m_rt::interrupt` can't be directly used; it must first be imported from a device crate, which re-exports `cortex_m_rt::interrupt`. This is required to check at compile time that the interrupt is valid for the target device. Safe `static mut` variables can be used with `#[interrupt]` handlers. The syntax is the same as `#[exception]`s. More background information can be found in #109. The companion svd2rust PR is rust-embedded/svd2rust#235 r? @rust-embedded/cortex-m Co-authored-by: Jorge Aparicio <[email protected]> Co-authored-by: Adam Greig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a breaking change because
it bumps the cortex-m-rt version requirement to v0.6.4
it changes the behavior of the
<device>::interruptitem. This item was abang macro and now has become an attribute.