make non cortex-m targets compile on stable #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it doesn't seem to be needed anymore
replace with an inherent `try_from` implementation
japaric
added
breaking-change
S-waiting-on-review
therealprof
approved these changes
Nov 11, 2018
|
bors r=therealprof |
bors bot
added a commit
that referenced
this pull request
Nov 14, 2018
252: make non cortex-m targets compile on stable r=therealprof a=japaric see individual commits for details this is a breaking change Co-authored-by: Jorge Aparicio <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commits for details
this is a breaking change