sizes, 64bit #341
sizes, 64bit #341
Conversation
rust-highfive
added
S-waiting-on-review
|
|
src/util.rs
Outdated
| t.append(if h2 != 0 { | ||
| let (h4, h3, h2, h1) = ((n >> 48) & 0xffff, (n >> 32) & 0xffff, (n >> 16) & 0xffff, n & 0xffff); | ||
| t.append(if n == 1 { | ||
| Ident::from("1") |
There was a problem hiding this comment.
This special case is weird...
There was a problem hiding this comment.
Getting rid of it? I'd fully expect this function to always return a real hex literal, not a hex literal or "1".
There was a problem hiding this comment.
Or you about "1"? I can delete this.
There was a problem hiding this comment.
Yes, I don't like a function called hex to treat the number 1 special and not turn it into hex. ;)
|
I was kind of hoping that at some point we could get rid of the custom formatting hacks but at the moment there still seems to be no way to generate lint-less long literals with the built-in formatting mechanics... |
|
Don't merge. Something wrong. |
|
Fixed. |
|
Looks great. Can you pleasse add a CHANGELOG entry, too? That way we don't have to hunt down all changes after the fact. ;) |
|
Done. |
|
bors r+ |
341: sizes, 64bit r=therealprof a=burrbull r? @therealprof Right use of cluster.size + better support of 64bit registers. See #299 , partially closed in #325 . Not tested yet. Co-authored-by: Andrey Zgarbul <[email protected]>
Build succeeded |
r? @therealprof
Right use of cluster.size + better support of 64bit registers.
See #299 , partially closed in #325 .
Not tested yet.