Skip to content

Add a .unique() method to Iterator. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Wilfred
Copy link

@Wilfred Wilfred commented May 31, 2015

I've found it very useful to be able to discard duplicates from iterators. I think this would be a useful addition to itertools, what do you think?

@bluss
Copy link
Member

bluss commented May 31, 2015

Hi, that sounds useful. What do you think about this:

  • It should be in the itertools trait
  • Use a single struct, not a struct and a trait.
  • Add it in the form of .unique_by with the closure giving the key
  • You're welcome to put it in a new module, but not a public submodule.

@bluss
Copy link
Member

bluss commented Jun 17, 2015

This was superseded by PR #37

@bluss bluss closed this Jun 17, 2015
@Wilfred Wilfred deleted the unique branch September 2, 2015 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants