This repository was archived by the owner on Aug 16, 2021. It is now read-only.
Allow skipping the Msg variant
#228
Merged
+109
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems nice! Could you update the doc? |
|
Sorry for the delay, could you rebase? |
While the `Msg` variant may be a useful option for some users, many will prefer to stick to more descriptive error types, and won't want this variant present. This allows a `skip_msg_variant` flag to be passed to `error_chain!`, which will cause no `Msg` variant to be present in the generated code. I've also refactored the body of `impl_error_chain_processing` to not care about the number of arguments other than the final branch, so more cases can be added in the future without having to touch as many places as I did. Fixes rust-lang-deprecated#200.
sgrif
force-pushed
the
sg-allow-skipping-msg-variant
branch
from
2ed56b8 to
b162068
Compare
|
Thanks! I like it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the
Msgvariant may be a useful option for some users, many willprefer to stick to more descriptive error types, and won't want this
variant present. This allows a
skip_msg_variantflag to be passed toerror_chain!, which will cause noMsgvariant to be present in thegenerated code.
I've also refactored the body of
impl_error_chain_processingto notcare about the number of arguments other than the final branch, so more
cases can be added in the future without having to touch as many places
as I did.
Fixes #200.