This repository was archived by the owner on Nov 21, 2018. It is now read-only.
Copy cargo bins from rust-lang-ci to static-rust-lang-org #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how cargo packages are handled during manifest creation. Before building manifests it downloads all tarballs to the local equivalent of
dist/, where it will be signed and uploaded by buildbot, both todist/and to the archives.It encodes the static.rust-lang.org archive urls into the manifest.
Because all cargo bins are called 'cargo-nightly', and all three rust channels have to coexist, it renames the cargo tarballs on beta and stable per the existing rust naming conventions, so on beta, it's
cargo-beta, and on stable it's e.g.cargo-0.17.0.cc rust-lang/rust#38519
I have tested in dev, but not end-to-end. I've seen it run and build a manifest that looks correct, but haven't seen buildbot actually do the build, run the script, upload everything, and rustup continue to work. I'll start that build now and hopefully be able to test rustup in dev tomorrow.
r? @alexcrichton