This repository was archived by the owner on Dec 1, 2023. It is now read-only.
Upgrade to rustc 1.0.0-nightly (fed12499e 2015-03-03) (built 2015-03-04) #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code only detected overflow to exactly zero (`u64::MAX + 1`). Tested on `multirust override nightly-2015-03-01` (before rust-lang/rust#22532)
Used checked arithmetic rather than checking for overflow after the fact. Another option is to keep checking after the fact and use wrapping arithmetic.
…ex_escape The overflow was introduced accidentally in 49d4958 and happened to cancel out.
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
I personally like this approach, thanks! |
alexcrichton
added a commit
that referenced
this pull request
Mar 4, 2015
Upgrade to rustc 1.0.0-nightly (fed12499e 2015-03-03) (built 2015-03-04)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one failure left in
cargo testbecause of rust-random/rand#21