This repository was archived by the owner on Dec 1, 2023. It is now read-only.
Fixed Index trait and new PathBuf::new() #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @alexcrichton (can't handle this at the moment) |
|
Thanks! We'll be sure to merge this once there's a new nightly available |
| @@ -570,14 +570,18 @@ impl Decodable for path::PathBuf { | |||
| use std::os::unix::prelude::*; | |||
| let bytes: Vec<u8> = try!(Decodable::decode(d)); | |||
| let s: OsString = OsStringExt::from_vec(bytes); | |||
| Ok(path::PathBuf::new(&s)) | |||
| let mut p = path::PathBuf::new(); | |||
| p.push(s); | |||
There was a problem hiding this comment.
I'm a bit unsure about this part. I hate mut. Might it be better to use FromIterator here?
There was a problem hiding this comment.
Oh this can actually just be replaced with Ok(PathBuf::from(s))
|
Ah ok, didn't know about from. Changed it now. |
alexcrichton
added a commit
that referenced
this pull request
Mar 25, 2015
Fixed Index trait and new PathBuf::new()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.