Fix typo and improve Japanese #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaneli
commented
Nov 28, 2016
| @@ -364,7 +364,6 @@ int32_t register_callback(void* callback_target, rust_callback callback) { | |||
| } | |||
|
|
|||
| void trigger_callback() { | |||
| # // cb(cb_target, 7); // Will call callback(&rustObject, 7) in Rust | |||
There was a problem hiding this comment.
Cシンタックスのためか、非表示とならずドキュメントにそのまま表示されていたので削除しました。
There was a problem hiding this comment.
1つ上のコードブロックでは消してるのにこちらは処理し忘れてますね。細かいところまでありがとうございます。
KeenS
approved these changes
Nov 28, 2016
|
ありがとうございます。マージします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.