Avoid using "into" when explaining to_*
#221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description "Conversions prefixed `to_`, on the other hand, typically stay at the same level of abstraction but do some work to change one representation into another." risks overlapping the ideas of `to_` and `into_` to memory. Instead using "from... to" helps reduce that overlap by using to with `to_`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description "Conversions prefixed
to_, on the other hand, typically stay at the same level of abstraction but do some work to change one representation into another." risks overlapping the ideas ofto_andinto_to memory. Instead using "from... to" helps reduce that overlap by using to withto_.