Leak dbghelp.dll like CoreSymbolication on OSX
#198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the MSVC code to leak `dbghelp.dll` on Windows after we initially load it. This allows for cheaper reuse between invocations and avoids each backtrace call having to load/unload an entire DLL. While not profiled just yet given #197 we're going to have to preserve *something* across calls in and out of this library, so this is going to be a first required step in any case to doing so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the MSVC code to leak
dbghelp.dllon Windows afterwe initially load it. This allows for cheaper reuse between invocations
and avoids each backtrace call having to load/unload an entire DLL.
While not profiled just yet given #197 we're going to have to preserve
something across calls in and out of this library, so this is going to
be a first required step in any case to doing so.