More improvements to gimli support #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate to `goblin` instead of `object` to reduce dependencies * Disable as many features as we can along the way, slimming down dependencies * Add rudimentary support for Windows MinGW * Don't consult symbol tables in files and instead assume `dladdr` does that for us * Add a lifetime parameter to the inner `Symbol` so the gimli bindings can be expressed a bit more safely.
alexcrichton
force-pushed
the
gimli-no-object
branch
from
87920b8 to
d3fb904
Compare
I think that will only use |
|
Yeah I've started seeing a few more |
|
Ok tests are indeed failing right now when debuginfo is missing but due to other reasons they're already disabled. I'll work on fixing that once 1.36.0 is out! |
alexcrichton
added a commit
that referenced
this pull request
Jul 8, 2019
This restores logic removed in #217 to search the symbol tables when looking for symbol name information, consequently fixing a test which was failing when turned on for gimli.
alexcrichton
added a commit
that referenced
this pull request
Jul 8, 2019
This restores logic removed in #217 to search the symbol tables when looking for symbol name information, consequently fixing a test which was failing when turned on for gimli.
|
Ok I've gotten around now to implementing this again |
alexcrichton
added a commit
that referenced
this pull request
Jul 8, 2019
This restores logic removed in #217 to search the symbol tables when looking for symbol name information, consequently fixing a test which was failing when turned on for gimli.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goblininstead ofobjectto reduce dependenciesdladdrdoesthat for us
Symbolso the gimli bindingscan be expressed a bit more safely.