Avoid transmutes with Context
#429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit re-consolidates transmutes around `Context` to just one location to ensure that this is in as few places as possible. This reorganizes the location of the `map_sup` variable and places it inside of `Stash` instead which is a sort of auxiliary bag for extra information that can be referenced anyway. Afterwards with some refactoring an a new `Mapping::mk` function it's back to one transmute, yay!
alexcrichton
force-pushed
the
less-transmute
branch
from
da2d493 to
a5d0af8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit re-consolidates transmutes around
Contextto just onelocation to ensure that this is in as few places as possible. This
reorganizes the location of the
map_supvariable and places it insideof
Stashinstead which is a sort of auxiliary bag for extrainformation that can be referenced anyway. Afterwards with some
refactoring an a new
Mapping::mkfunction it's back to one transmute,yay!