Announce async fn and return-position impl Trait in traits
#1180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crlf0710
reviewed
Dec 20, 2023
traviscross
reviewed
Dec 20, 2023
traviscross
reviewed
Dec 20, 2023
traviscross
reviewed
Dec 20, 2023
traviscross
reviewed
Dec 20, 2023
yoshuawuyts
reviewed
Dec 20, 2023
nikomatsakis
approved these changes
Dec 20, 2023
traviscross
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
As @nikomatsakis also mentioned, overall this looks really great, and it will be exciting to get this out with RPITIT and AFIT.
Co-authored-by: Travis Cross <[email protected]> Co-authored-by: Yosh <[email protected]> Co-authored-by: Niko Matsakis <[email protected]>
And add a note about why we don't warn on non-public traits.
slanterns
reviewed
Dec 20, 2023
|
cc @Mark-Simulacrum, since this will be linked from the release blog post |
traviscross
approved these changes
Dec 21, 2023
Co-authored-by: Travis Cross <[email protected]>
After reading through it just felt too disruptive in the first section, and there isn't really a good place to put it. The FAQ still addresses the question.
And clarify footnote
|
Thanks for the feedback, everyone! I think this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rust-lang/wg-async