Skip to content

Fix clippy warnings #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Fix clippy warnings #1210

merged 3 commits into from
Jan 18, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 11, 2024

Together with #1208 and #1209, this fixes the remaining clippy warnings that prevent us from introducing a cargo clippy run to the CI workflow.

@Turbo87
Copy link
Member Author

Turbo87 commented Jan 18, 2024

r? @rust-lang/website

@Mark-Simulacrum
Copy link
Member

I don't mind the warnings showing up, but we're not planning to gate CI on clippy, right? That will potentially harm our ability to deploy release blog posts if there's new warnings in the new release, which isn't great. (Or typo fixes post merge depending on when exactly we enforce).

@Manishearth Manishearth merged commit ecaa79e into rust-lang:master Jan 18, 2024
@Turbo87
Copy link
Member Author

Turbo87 commented Jan 18, 2024

I don't mind the warnings showing up, but we're not planning to gate CI on clippy, right?

I was planning on doing that, but with a fixed Rust version that renovatebot updates whenever there is a new stable release. I'm not a big fan of having moving targets on CI, precisely because I want to avoid a broken CI for reasons unrelated to a PR.

@Turbo87 Turbo87 deleted the clippy-warnings branch January 18, 2024 20:55
@Mark-Simulacrum
Copy link
Member

Sounds good!

This was referenced Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants