Remove duplicate commandline prompt in console block displays
#1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noritada
changed the title
console blocksconsole block displays
Turbo87
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
looks like this weird behavior was introduced by 1849fd7, but I don't see any justification for it in the git history.
IMHO it would be better / less surprising to remove the ::before part, but this is still a good short-term fix. thanks!
|
this was how it was previously looking on production: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes duplicate commandline prompt in
consoleblocks.Thank you for taking the time.