Skip to content

Improve table's css #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2017
Merged

Conversation

GuillaumeGomez
Copy link
Member

Fixes #154.

@GuillaumeGomez
Copy link
Member Author

A little screenshot:

screen shot 2017-03-16 at 23 10 50

css/main.scss Outdated

td, th {
border-bottom: 1px solid #eee;
border-right: 1px solid #eee;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This doesn't match the indentation of the previous lines

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol at that gnarly @import indentation above

@steveklabnik
Copy link
Member

looks like this is a bit different than #154 (comment), any specific reasons why?

@GuillaumeGomez
Copy link
Member Author

@steveklabnik: I can fix it as well as they suggested but I won't from the CSS.

@GuillaumeGomez
Copy link
Member Author

So I "rotated" the table. I think it's the closest to what they want if I'm not wrong?

@steveklabnik
Copy link
Member

Sorry, I mean the CSS changes are different than those ones.

@lqd
Copy link
Member

lqd commented Mar 16, 2017

(btw it seems the tables are missing the 15px bottom margin that a lot of the other elements have from base.scss — + tiny typo there with "vertycal" — which is making the paragraph following them "stick" to the table without spacing :)

@GuillaumeGomez
Copy link
Member Author

Updated with @lqd's remarks.

@steveklabnik
Copy link
Member

Let's :shipit:

@steveklabnik steveklabnik merged commit ae6fb08 into rust-lang:gh-pages Mar 16, 2017
@GuillaumeGomez GuillaumeGomez deleted the patch-1 branch March 16, 2017 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants