Libz blitz #164
Merged
Libz blitz #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewsxcv
reviewed
May 4, 2017
_posts/2017-05-05-libz-blitz.md
Outdated
| "use ownership to encapsulate invariants"; consistent naming conventions like | ||
| `mut`, `ref`, `as`, `into`, that let users intuit what they don't know | ||
| from what they do; small details of presentation that add up, like consistently | ||
| documentating possible error cases in a dedicated "Errors" section; and so many |
|
cc @rust-lang/core |
frewsxcv
reviewed
May 4, 2017
_posts/2017-05-05-libz-blitz.md
Outdated
|
|
||
| Because of Cargo, we can "include batteries" without literally putting them into | ||
| the standard library; pulling in other crates is nearly as easy as using the | ||
| standard library (and will get even easier this year). But to capitalize on this |
There was a problem hiding this comment.
Out of curiosity, is "will get even easier this year" referring to something in particular?
sebasmagri
reviewed
May 4, 2017
_posts/2017-05-05-libz-blitz.md
Outdated
| evaluation grow in scope, presumably the tasks that arise will grow as well. | ||
|
|
||
| [`byteorder`]: https://docs.rs/byteorder | ||
| [`bitflags`]: https://doc.rust-lang.org/tempdir/tempdir/index.html |
There was a problem hiding this comment.
Should this point to https://docs.rs/bitflags/?
steveklabnik
reviewed
May 4, 2017
_posts/2017-05-05-libz-blitz.md
Outdated
| broader community will also apply this process completely independently to | ||
| crates the libs team won't have time to discuss. | ||
|
|
||
| ### How to help |
There was a problem hiding this comment.
Maybe consider phrasing this as a question, given the first sentence.
dtolnay
reviewed
May 4, 2017
_posts/2017-05-05-libz-blitz.md
Outdated
| ### Rust standards of community | ||
|
|
||
| We have some idea of what goes into publishing exceptional Rust crates, but the | ||
| Rust library team is not the sole authority of Rust API design — the Rust crate |
There was a problem hiding this comment.
Em dash should be used without spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No merge.
cc @aturon @dtolnay @rust-lang/libs