-
Notifications
You must be signed in to change notification settings - Fork 303
Fix image positioning #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
The thumbnail classes are added back via raw html, which is labeled 'unsafe' in comrak. AFAIK, it should be perfectly fine as long as only trusted markdown input is processed though. |
Thanks @jplatte ! Unfortunately, there are now merge conflicts, maybe you can rebase? |
Of course. I was expecting the merge conflicts even when opening the PR, but forgot to update this one after the other one was merged 😅 I've fixed the conflicts now. |
@jplatte thanks for fixing the conflicts -- can you however use a rebase instead of a merge commit? (Although I wonder if GH's "rebase and merge" or "squash and merge" options would do that for you) |
Yeah I can rebase later. Unfortunately I can't do it in the web interface. Rebase and merge / squash and merge are only available to people with write access, and if there are no conflicts. |
(was broken with the move from Ruby to Rust site generation)
@nikomatsakis done |
Thanks @jplatte ! |
If the first and/or last commit are unwanted, I can force-push a version with just the actual image positioning changes (or you can cherry-pick those two commits).
fixes #414