-
Notifications
You must be signed in to change notification settings - Fork 303
Fix (and improve) enum representation of an async fn future #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`g: MutexGuard<'_, u32>` does not exist in the scope of the "unresumed" generator / future, so this fixes it. On top of that, I have taken the freedom to add a the `Return` variant to the enum, and have also added some comments on top of it, in order to have a precise recap' of the cited post about generators.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
r? @davidtwco |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I've left a few comments below.
posts/inside-rust/2019-10-11-AsyncAwait-Not-Send-Error-Improvements.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2019-10-11-AsyncAwait-Not-Send-Error-Improvements.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2019-10-11-AsyncAwait-Not-Send-Error-Improvements.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2019-10-11-AsyncAwait-Not-Send-Error-Improvements.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2019-10-11-AsyncAwait-Not-Send-Error-Improvements.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2019-10-11-AsyncAwait-Not-Send-Error-Improvements.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2019-10-11-AsyncAwait-Not-Send-Error-Improvements.md
Outdated
Show resolved
Hide resolved
Co-authored-by: David Wood <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielhenrymantilla thanks!
@alexcrichton can you merge this? I'm not sure I have permissions for this repository.
👍 |
g: MutexGuard<'_, u32>
does not exist in the scope of the "unresumed" generator / future, so this fixes it.On top of that, I have taken the freedom to add a the
Return
variant to the enum, and have also added some comments on top of it, in order to have a precise recap' of the cited post about generators.