Skip to content

New inside-rust blog post -- The Rustc Learning Working Group - An Introduction #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 28, 2019
Merged

New inside-rust blog post -- The Rustc Learning Working Group - An Introduction #438

merged 5 commits into from
Oct 28, 2019

Conversation

amanjeev
Copy link
Member

@amanjeev amanjeev commented Oct 26, 2019

Hi, I wrote a blog post, as promised a while ago, about the Learning Working Group. Please let me know if you see it a good fit for the blog or needs improvements. Thank you.

The promise of blog post was made here https://rust-lang.zulipchat.com/#narrow/stream/196385-t-compiler.2Fwg-learning/topic/blog/near/177905642

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@spastorino
Copy link
Member

spastorino commented Oct 26, 2019

@amanjeev this is great ❤️ ❤️ ❤️. Just loudly thinking ... maybe we can make a more direct invitation for people to get involved at the end, something like, if you're interested in this effort, please join us on Zulip, introduce yourself, let us know what do you find interesting about the effort and we can collaborate make rustc-guide better. Something maybe along those lines but better written maybe?.

@amanjeev
Copy link
Member Author

@spastorino I added a small section for call for participation, inspired by your points above. Please check.

@amanjeev
Copy link
Member Author

@spastorino Made the changes per your suggestion. Please let me know if I missed something.

Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@amanjeev
Copy link
Member Author

Please let me know how we merge this.

@spastorino
Copy link
Member

Please let me know how we merge this.

IMO is ready, I guess we just need @nikomatsakis to pass around this PR and he will merge it. I know Niko is very busy but he will come around at some point and do so :).

…rning working group because the post is from the working group and not the entire compiler team
@alexcrichton
Copy link
Member

r? @nikomatsakis

title: "The Rustc Learning Working Group - An Introduction"
author: Amanjeev Sethi
description: "introduction learning working group useful links"
team: the learning working group <https://www.rust-lang.org/governance/teams/compiler#wg-learning>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
team: the learning working group <https://www.rust-lang.org/governance/teams/compiler#wg-learning>
team: the rustc learning working group <https://www.rust-lang.org/governance/teams/compiler#wg-learning>

(I wonder if we should rename this -- it sounds so much more general than it is)

…n.md to 2019-10-28-rustc-learning-working-group-introduction.md
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made changes myself

@nikomatsakis nikomatsakis merged commit d325054 into rust-lang:master Oct 28, 2019
@amanjeev amanjeev deleted the amanjeev/rustc-learning-wg-intro branch October 28, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants