Fix profile directory in crate graph self-profiling example #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the rustc self-profiling blog post, the proposed crate graph-wide self-profiling command is incorrect. ```sh $ RUSTFLAGS="-Zself-profile=./profiles -Zself-profile-events=default,args" cargo build ``` The problem is that the `./profiles` relative directory will be resolved with respect to whatever directory rustc happens to be working in at the time where the RUSTFLAGS are parsed. Which, for dependency crates, will be the source directory of those dependencies, not the source directory of the crate that we are working on. Forcing directory resolution to be relative to the active crate's directory by replacing the rustc-evaluated `.` with a shell-evaluated `$(pwd)` resolves this problem. Kudos to @bjorn3 for figuring this out!
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
r? @wesleywiser |
wesleywiser
approved these changes
Mar 1, 2020
|
@bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the rustc self-profiling blog post, the proposed crate graph-wide self-profiling command is incorrect.
$ RUSTFLAGS="-Zself-profile=./profiles -Zself-profile-events=default,args" cargo buildThe problem is that the
./profilesrelative directory will be resolved with respect to whatever directory rustc happens to be working in at the time where the RUSTFLAGS are parsed. Which, for dependency crates, will be the source directory of those dependencies, not the source directory of the crate that we are working on.Forcing directory resolution to be relative to the active crate's directory by replacing the rustc-evaluated
.with a shell-evaluated$(pwd)resolves this problem.Kudos to @bjorn3 for figuring this out!