Skip to content

Enable SmartyPants for Better Typography #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2015

Conversation

killercup
Copy link
Member

Enables transforming things like "--" to "–" and "we'll" to "we’ll".

Enables transforming things like "--" to "–" and "we'll" to "we’ll".
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@killercup
Copy link
Member Author

I noticed that http://blog.rust-lang.org/2015/04/24/Rust-Once-Run-Everywhere.html could benefit from some typographic enhancements. This just adds the "smarty pants" extension to Redcarpet (as seen in the Jekyll documentation).

@steveklabnik
Copy link
Member

I'm afraid of things like this due to lifetimes: they shouldn't be curly. Do you know how this interacts with this?

@killercup
Copy link
Member Author

I would be surprised if this did anything to text in back ticks or code blocks. I'll try it locally and see what happens, though.

On Sat, Apr 25, 2015 at 12:40 AM, Steve Klabnik [email protected]
wrote:

I'm afraid of things like this due to lifetimes: they shouldn't be curly. Do you know how this interacts with this?

Reply to this email directly or view it on GitHub:
#53 (comment)

@killercup
Copy link
Member Author

@steveklabnik, lifetimes render as expected, 'a stays 'a. SmartyPants ignores inline code and code blocks.

@steveklabnik
Copy link
Member

Seems fine then, thank you!

steveklabnik added a commit that referenced this pull request Apr 25, 2015
Enable SmartyPants for Better Typography
@steveklabnik steveklabnik merged commit 85a437d into rust-lang:gh-pages Apr 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants