Skip to content

Add initial draft of side effect post #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2020

Conversation

Mark-Simulacrum
Copy link
Member

I tried to draft the state of the world as I know it, but I'm sure I missed things or at least it feels like I am :) There's probably also some room for headings... but I'm not quite sure yet how those should look.

Happy to hear feedback!

cc @nikic
r? @nikomatsakis

@Mark-Simulacrum
Copy link
Member Author

cc rust-lang/compiler-team#177 as well

Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! Left a few thoughts below.

@Mark-Simulacrum
Copy link
Member Author

cc @rust-lang/compiler -- before we post this (tentatively next Thursday), would be good to get some more eyes on it to see if we can perhaps find some concrete questions to ask or if the wording anywhere is misleading.

Copy link
Member

@nagisa nagisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanation looks very accurate on a first read.

@Mark-Simulacrum Mark-Simulacrum merged commit aa7e094 into rust-lang:master Mar 19, 2020
@Mark-Simulacrum Mark-Simulacrum deleted the side-effect branch March 19, 2020 18:31
steveklabnik pushed a commit that referenced this pull request Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants