Skip to content

Use GitHub Action for deployment. #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Use GitHub Action for deployment. #577

merged 2 commits into from
Apr 29, 2020

Conversation

XAMPPRocky
Copy link
Member

This allows using the repo's GITHUB_TOKEN and will only push when there's actual changes.

This allows using the repo's `GITHUB_TOKEN` and will only push when there's actual changes.
@rust-highfive
Copy link

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@pietroalbini
Copy link
Member

r? @pietroalbini

This mostly looks fine. While reviewing the PR, I noticed both the new and the old versions don't create a .nojekyll file at the root of the deployed website, while that file should be created to avoid extra preprocessing by GitHub.

Could you add that? A simple touch site/.nojekyll should be enough.

@XAMPPRocky
Copy link
Member Author

@pietroalbini Done.

@pietroalbini pietroalbini merged commit 934ee34 into master Apr 29, 2020
@pietroalbini pietroalbini deleted the deploy-action branch April 29, 2020 13:36
@pietroalbini
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants