-
Notifications
You must be signed in to change notification settings - Fork 303
Add Five Years of Rust post #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think it would be nice to include some dates in the timeline. We probably don't need the exact date for every entry, but it would probably be nice to break the releases list up by year; what does everyone else think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some semicolons that should be colons
Co-authored-by: Kyle J Strand <[email protected]>
Co-authored-by: Kyle J Strand <[email protected]>
I meant to add years but totally forgot, I've now updated it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, it was really fun reading through all the new things which happened in the releases!
error: aborting due to 2 previous errors | ||
Could not compile `error-messages`. | ||
|
||
To learn more, run the command again with --verbose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need text and images for the error messages? Seems a bit like overkill
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nrc It's a compromise, as neither representation is ideal.
The text based versions don't show the work that has gone into colour and emphasis as part of the error message, and have the problem on mobile where you can only see half (vertically) of the text at a time.
The images do show the colour & font work, but can also be hard to read on mobile because the images are landscape and most view the web in portrait. Also if you rely on a screenreader you would otherwise have no way of telling what the error message looks like. Having both lets the reader choose the representation that most readable for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Can I add a quote?
If I had to pick one thing I'm most proud of, it was the work on non-lexical lifetimes (NLL). It's not only because I think it made a big difference in the usability of Rust, but also because of the way that we implemented it by forming the NLL working group. This working group brought in a lot of great contributors, many of whom are still working on the compiler today. Open source at its best!
Co-authored-by: Vadim Petrochenkov <[email protected]>
Co-authored-by: Pietro Albini <[email protected]>
Co-authored-by: Pietro Albini <[email protected]>
Co-authored-by: Ralf Jung <[email protected]>
Co-authored-by: Ralf Jung <[email protected]>
Co-authored-by: Ralf Jung <[email protected]>
Co-authored-by: Ralf Jung <[email protected]>
Co-authored-by: Ralf Jung <[email protected]>
Today's the day, if there's no last minute changes or quotes from people I'll merge this at ~1pm CEST (6 hours from now). |
Co-authored-by: Istratov Dmitrii <[email protected]>
* Added Five Years of Rust post * Update posts/2020-05-15-five-years-of-rust.md Co-authored-by: Kyle J Strand <[email protected]> * Update posts/2020-05-15-five-years-of-rust.md Co-authored-by: Kyle J Strand <[email protected]> * Add full stop * Add year subsections * Update posts/2020-05-15-five-years-of-rust.md Co-authored-by: Nick Cameron <[email protected]> * Add Niko's quote & address some feedback * Update 2020-05-15-five-years-of-rust.md * Update 2020-05-15-five-years-of-rust.md * Update 2020-05-15-five-years-of-rust.md * Update posts/2020-05-15-five-years-of-rust.md Co-authored-by: Vadim Petrochenkov <[email protected]> * Update 2020-05-15-five-years-of-rust.md * Update posts/2020-05-15-five-years-of-rust.md Co-authored-by: Manish Goregaokar <[email protected]> * Update 2020-05-15-five-years-of-rust.md * Update 2020-05-15-five-years-of-rust.md * Update 2020-05-15-five-years-of-rust.md * Update posts/2020-05-15-five-years-of-rust.md Co-authored-by: Pietro Albini <[email protected]> * Update posts/2020-05-15-five-years-of-rust.md Co-authored-by: Pietro Albini <[email protected]> * Update 2020-05-15-five-years-of-rust.md * Update 2020-05-15-five-years-of-rust.md * Update posts/2020-05-15-five-years-of-rust.md Co-authored-by: Ralf Jung <[email protected]> * Update posts/2020-05-15-five-years-of-rust.md Co-authored-by: Ralf Jung <[email protected]> * Update posts/2020-05-15-five-years-of-rust.md Co-authored-by: Ralf Jung <[email protected]> * Update posts/2020-05-15-five-years-of-rust.md Co-authored-by: Ralf Jung <[email protected]> * Update 2020-05-15-five-years-of-rust.md * Update 2020-05-15-five-years-of-rust.md * Update posts/2020-05-15-five-years-of-rust.md Co-authored-by: Ralf Jung <[email protected]> * Update posts/2020-05-15-five-years-of-rust.md Co-authored-by: Istratov Dmitrii <[email protected]> * Update 2020-05-15-five-years-of-rust.md Co-authored-by: Kyle J Strand <[email protected]> Co-authored-by: Nick Cameron <[email protected]> Co-authored-by: Vadim Petrochenkov <[email protected]> Co-authored-by: Manish Goregaokar <[email protected]> Co-authored-by: Pietro Albini <[email protected]> Co-authored-by: Ralf Jung <[email protected]> Co-authored-by: Istratov Dmitrii <[email protected]>
Rendered
This PR also adds some initial styling for the
<blockquote>
element as previously the element applied no styling except for padding, which was less than ideal for the article. I've pasted a screenshot of how it looks below.r? @rust-lang/core I've attributed the post to the core team, since that was the author of previous annual posts.
Note You need to run locally to see the images in the content, I've also included them in the disclosure below.
Error Message Images
Desktop
Single Item

Mobile
Single Item
