Skip to content

Remove preloads of font files that do not exist #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2020
Merged

Remove preloads of font files that do not exist #592

merged 1 commit into from
May 15, 2020

Conversation

gszy
Copy link
Contributor

@gszy gszy commented May 15, 2020

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nikomatsakis
Copy link
Contributor

Seems fine to me but I'm not really familiar with this stuff

r? @XAMPPRocky

@XAMPPRocky
Copy link
Member

Yep this is fine, I already had this change in a local branch but never pushed it. We import the fonts through css.

@XAMPPRocky XAMPPRocky merged commit e34455d into rust-lang:master May 15, 2020
@gszy gszy deleted the remove-invalid-preloads branch May 17, 2020 13:22
jackh726 pushed a commit to jackh726/blog.rust-lang.org that referenced this pull request Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants