Ownership of the standard library implementation post #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Jun 23, 2020
bjorn3
reviewed
Jun 23, 2020
Co-authored-by: bjorn3 <[email protected]>
Co-authored-by: bjorn3 <[email protected]>
|
Thanks for the review @nikomatsakis! How’s this looking now? |
|
Looks great! |
|
Shall I merge? |
|
That would be great, thanks! 🚀 |
…ship-Std-Implementation.md
|
Updated the date to match today, merging. Thank you again for your PR! |
jackh726
pushed a commit
to jackh726/blog.rust-lang.org
that referenced
this pull request
Jul 26, 2021
* Create 2020-06-23-Ownership-Std-Implementation.md * Update 2020-06-23-Ownership-Std-Implementation.md * Update 2020-06-23-Ownership-Std-Implementation.md * Update posts/inside-rust/2020-06-23-Ownership-Std-Implementation.md Co-authored-by: bjorn3 <[email protected]> * Update posts/inside-rust/2020-06-23-Ownership-Std-Implementation.md Co-authored-by: bjorn3 <[email protected]> * Update and reformat based on review feedback * Rename 2020-06-23-Ownership-Std-Implementation.md to 2020-07-02-Ownership-Std-Implementation.md Co-authored-by: bjorn3 <[email protected]> Co-authored-by: XAMPPRocky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed this with the compiler team in rust-lang/compiler-team#267 and it was suggested in rust-lang/rust-forge#361 that we should write something for the blog about sharing standard library work between Libs and Compiler.
Do you think I should include a few more breadcrumb links in the post itself to @dtolnay's original proposal?
r? @dtolnay @pnkfelix