Fixed wording in Rust 1.45 Blog Post #654
Conversation
|
How about "there is not |
posts/2020-07-16-Rust-1.45.0.md
Outdated
| keyword has not be specified in this code block. This is what we call a | ||
| "soundness" bug, that is, it is a bug where the compiler does the wrong thing. |
There was a problem hiding this comment.
| keyword has not be specified in this code block. This is what we call a | |
| "soundness" bug, that is, it is a bug where the compiler does the wrong thing. | |
| keyword has not been specified in this code block. This is what we call a | |
| "soundness" bug, where the compiler does the wrong thing. |
minor suggestion re be vs been. using that is in the middle of a sentence is pretty weird as well, so maybe we can get two fixes in one.
There was a problem hiding this comment.
This suggestion is good re: grammar, but using "specified" here sounds odd, because specification has a different meaning, technically.
I can appreciate this sentence maybe sounding odd, but I think moving it in this direction makes it sound more odd, not less.
There was a problem hiding this comment.
Oops, yeah the "be" was a typo. Ironic.
There was a problem hiding this comment.
What about
But the unsafe keyword is nowhere to be found within this block of code.
?
There was a problem hiding this comment.
I prefer this latter formulation, fwiw.
|
r? @steveklabnik || @pietroalbini |
|
I pushed up the 2nd proposal for the change. Feel free to close this PR if there are remaining objections to it. Thanks guys. |
Co-authored-by: Niko Matsakis <[email protected]>
This sentence read a little awkwardly to me, so I tried to make it more clear.