-
Notifications
You must be signed in to change notification settings - Fork 303
Launching the Lock Poisoning Survey #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You are only talking about poisoning as a way to maintain invariants, while in my opinion poisoning is just as much about easily propagating panics between threads, even when not taking panics into consideration, as |
@bjorn3 The post comes around to that same conclusion, that lock poisoning is more a tool for propagating panics, rather than a tool for directly protecting from broken invariants. |
Missed that part. |
It's a nice bit of validation to know you independently have a similar impression on what lock poisoning does and doesn't do 😁 |
I’ve just pushed a small update to the end of the post to be less strongly worded towards removing poisoning, since part of the survey will be telling us how useful it actually is for everyone. I’ve also updated the publish date so I think we should be good to merge now! |
@Mark-Simulacrum I think this one's just been waiting for some Core team approval for a while (but that might not have been very clear from the thread here). Would it be easier to publish if I targeted the insiders blog instead of the main one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to bump the date to Friday I think it'd be fine to merge this - left a few additional comments too
Thanks @Mark-Simulacrum 🙇 I’ve updated the post. |
We've been talking about running a survey to see how the standard library's locks are used in the wild. This post announces that survey along with a bit of a description of what poisoning is all about.
We started an FCP for the survey over here: rust-lang/libs-team#5
r? @sfackler @withoutboats