Skip to content

Add release flag to prior-1.32 blog posts #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2020
Merged

Add release flag to prior-1.32 blog posts #737

merged 2 commits into from
Dec 13, 2020

Conversation

Folyd
Copy link
Contributor

@Folyd Folyd commented Dec 12, 2020 •
edited
Loading

No description provided.

@Folyd Folyd requested a review from a team December 12, 2020 16:17
@Folyd Folyd requested a review from a team as a code owner December 12, 2020 16:17
Mark-Simulacrum
Mark-Simulacrum reviewed Dec 12, 2020
View reviewed changes
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you say more about your intent with this PR? It looks like it's aiming to add the version number for releases, but currently Rust infra doesn't consume that. I am not see any optimizations either, so not quite sure what you meant there.

I would prefer to drop the clippy and .gitignore changes from this PR regardless.

@Folyd Folyd changed the title Optimize blog-post release feed render process Add release flag to prior-1.32 blog posts Dec 13, 2020
@Folyd
Copy link
Contributor Author

Folyd commented Dec 13, 2020

Can you say more about your intent with this PR? It looks like it's aiming to add the version number for releases, but currently Rust infra doesn't consume that. I am not see any optimizations either, so not quite sure what you meant there.

I would prefer to drop the clippy and .gitignore changes from this PR regardless.

Thanks for reviewing. I rectified the title of this PR and dropt the clippy and .gitignore changes.

@Mark-Simulacrum Mark-Simulacrum merged commit 4078bb1 into rust-lang:master Dec 13, 2020
jackh726 pushed a commit to jackh726/blog.rust-lang.org that referenced this pull request Jul 26, 2021
@Folyd @jackh726
Add release flag to prior-1.32 blog posts (rust-lang#737)
5e1e002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Folyd @Mark-Simulacrum @bjorn3