Cache the target directory based on the compiler version #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietroalbini
force-pushed
the
fix-ci-cache
branch
from
2f2e403 to
78567aa
Compare
pietroalbini
force-pushed
the
fix-ci-cache
branch
from
aa40837 to
b0aa404
Compare
jyn514
reviewed
Dec 14, 2020
Manishearth
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Travis CI dynamically updated the caches after builds finished (with a different cache for each branch), GitHub Actions identifies each cache with a key and never updates a cache with the same key, even if the contents of the cached directory changed.
Before this PR, we cached the target directory based on the hash of the
Cargo.lockfile, which means the cache was never updated as long as theCargo.lockdidn't change. Unfortunately this was not enough, as the existing target directory is useless after a Rust version update. We also did not cache the crates.io index nor the downloaded dependencies.This PR changes the CI configuration to also include the Rust version in the cache key. This also adds caching for the crates.io index and the downloaded crates. This should speed up CI from 2.5 minutes to 30 seconds.