Clear CFLAGS and CXXFLAGS before tests #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some test cases check that a compiler flag is not present. But cc::Build loads additional flags from the CFLAGS and CXXFLAGS environment variables. If these are set, they might interfere with the test cases. Therefore we clear the CFLAGS and CXXFLAGS environment variables before running a test that requires an absent flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test cases check that a compiler flag is not present. But
cc::Buildloads additional flags from theCFLAGSandCXXFLAGSenvironment variables. If these are set, they might interfere with the test cases.Therefore this patch clears the
CFLAGSandCXXFLAGSenvironment variables before running a test case that requires an absent flag.This caused test failures in the Debian CI (example log). To reproduce the problem, run: