Use clang when cross-compiling to iOS targets #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lib.rs
Outdated
| @@ -2044,6 +2044,8 @@ impl Build { | |||
| } else { | |||
| format!("{}.exe", gnu) | |||
| } | |||
| } else if target.contains("ios") { | |||
There was a problem hiding this comment.
Could this perhaps use -ios- as a search string to be a bit more flexible? The string "ios" is a little short unfortunately...
There was a problem hiding this comment.
iOS has 7 different targets. See platform-support.
- aarch64-apple-ios
- x86_64-apple-ios
- aarch64-apple-ios-macabi
- armv7-apple-ios
- armv7s-apple-ios
- i386-apple-ios
- x86_64-apple-ios-macabi
It looks like apple-ios is the better choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the target flags to be set correctly when building for Mac Catalyst.