Use proper generator configuration in MinGW Windows toolchain #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lib.rs
Outdated
| // If make.exe isn't found, that means we may be using a MinGW | ||
| // toolchain instead of a MSYS2 toolchain. If neither is found, | ||
| // the build cannot continue. | ||
| let has_msys2 = Command::new("make").spawn().err() |
There was a problem hiding this comment.
Could this try to use something like make --version instead of make which could accidentally try to do some work? Additionally, could this use .output() to squelch all output and otherwise just test if the binary exists? (searching PATH would also be fine)
There was a problem hiding this comment.
Sure. I've made both of those changes in the new commit.
Add --version argument and change spawn() to output().
|
🥥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Windows builds where MSYS2 isn't installed, but MinGW is. Uses the technique described in #3 (comment).