Properly format DEP_XXX_ROOT #48
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When specifying a dependency on library "foo-bar" by calling `Config::register_dep`, the environment variable to read when setting `CMAKE_PREFIX_PATH` is `DEP_FOO_BAR_ROOT`. The previous version of `register_dep` would work only if passed "FOO_BAR". With this change, it also accepts the more natural library name, i.e. "foo-bar", and does the necessary formatting internally when deriving the environment variable name.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying a dependency on library "foo-bar" by calling
Config::register_dep, the environment variable to read when settingCMAKE_PREFIX_PATHisDEP_FOO_BAR_ROOT. The previous version ofregister_depwould work only if passed "FOO_BAR". With this change, it also accepts the more natural library name, i.e. "foo-bar", and does the necessary formatting internally when deriving the environment variable name.