Skip to content

Skip aeabi_cdcmp and aeabi_cfcmp on big-endian targets #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2018

Conversation

paoloteti
Copy link
Contributor

First of all aeabi_cdcmp and aeabi_cfcmp are never called LLVM.
Second are little-endian only, so build fail on big-endian targets as show below:

cargo:warning=./compiler-rt/lib/builtins/arm/aeabi_cdcmp.S:13:2: error: #error big endian support not implemented
cargo:warning= #error big endian support not implemented
cargo:warning=  ^~~~~

Temporally workaround: exclude these files for big-endian targets.

Tested on a Texas Instruments TMS570LS3137 (Cortex-R4F big-endian) based board.

First of all aeabi_cdcmp and aeabi_cfcmp are never called LLVM.
Second are little-endian only, so build fail on big-endian targets.
Temporally workaround: exclude these files for big-endian targets.
@alexcrichton
Copy link
Member

Thanks! Looks like there may be a build failure though?

Fix an unclosed if block
@alexcrichton alexcrichton merged commit 22f76e3 into rust-lang:master Jan 19, 2018
@alexcrichton
Copy link
Member

Thanks!

@paoloteti paoloteti deleted the be branch January 20, 2018 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants