Skip to content

Collection of VFP intrinsics #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2018
Merged

Collection of VFP intrinsics #231

merged 3 commits into from
Feb 13, 2018

Conversation

paoloteti
Copy link
Contributor

Nothing really exciting here, just a list of trivial VFP intrinsics.

First of all set mfloat-abi=hard not only for thumb targets, then add support for the following intrinsics:

 __gesf2vfp
 __gedf2vfp
 __gtsf2vfp
 __gtdf2vfp
 __ltsf2vfp
 __ltdf2vfp
 __nesf2vfp
 __nedf2vfp
 __eqsf2vfp
 __eqdf2vfp
 __extendsfdf2vfp

Resulting implementation is really trivial thanks to native code generated by LLVM on hard-float targets

Nothing really exciting here. LLVM on hard-float target use native instructions
for all listed VFP intrinsics and so resulting implementation is really trivial.

Implemented intrinsics:

 __gesf2vfp
 __gedf2vfp
 __gtsf2vfp
 __gtdf2vfp
 __ltsf2vfp
 __ltdf2vfp
 __nesf2vfp
 __nedf2vfp
 __eqsf2vfp
 __eqdf2vfp
 __extendsfdf2vfp
Already implemented, but not marked as done.
@alexcrichton
Copy link
Member

@bors: r+

Thanks!

When you get a chance, mind sending a PR to rust-lang/rust to update the compiler-builtins submodule?

@bors
Copy link
Contributor

bors commented Feb 12, 2018

📌 Commit 2467bd2 has been approved by alexcrichton

bors added a commit that referenced this pull request Feb 12, 2018
Collection of VFP intrinsics

Nothing really exciting here, just a list of trivial VFP intrinsics.

First of all set  `mfloat-abi=hard` not only for thumb targets, then add support for the following intrinsics:

```
 __gesf2vfp
 __gedf2vfp
 __gtsf2vfp
 __gtdf2vfp
 __ltsf2vfp
 __ltdf2vfp
 __nesf2vfp
 __nedf2vfp
 __eqsf2vfp
 __eqdf2vfp
 __extendsfdf2vfp
```
Resulting implementation is really trivial thanks to native code generated by LLVM on hard-float targets
@bors
Copy link
Contributor

bors commented Feb 12, 2018

⌛ Testing commit 2467bd2 with merge 266ea07...

@bors
Copy link
Contributor

bors commented Feb 13, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 266ea07 to master...

@bors bors merged commit 2467bd2 into rust-lang:master Feb 13, 2018
@paoloteti paoloteti deleted the vfp branch February 13, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants