Support aarch64 outlined atomics #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtriplett
force-pushed
the
outline-atomics
branch
from
dd399e3 to
14bbb92
Compare
|
The CI error here looks unrelated; it's about uses of the |
|
CI should be fixed by #417 |
|
Can you rebase on the latest master? |
llvm/llvm-project@a4ac434 saw the addition of out-of-line aarch64 atomic intrinsics. LLVM will sometimes emit these, so we need to ensure they're included in Rust's compiler-rt.
joshtriplett
force-pushed
the
outline-atomics
branch
from
14bbb92 to
9ed6cf2
Compare
|
Looks like the path to lse.S isn't correct, at least in CI. Investigating... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On aarch64, GCC and LLVM will now sometimes emit references to
out-of-line intrinsics for atomic operations, used to handle atomic
operations portably between systems with and without the "large-system
extensions" (LSE) introduced in ARM v8.1.
Add these intrinsics to Rust's compiler-rt, both for code generated by
Rust and for libraries a user might link in.
Based on the PR at
#407 .