Implement faster memcmp for x86_64 #467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On x86_64 it is generally fast to read unaligned words, so there is no need to do byte-by-byte comparisons.
The new algorithm compares 32 bytes at a time. If any doesn't match it effectively does a binary search to find the first non-matching byte.
Benchmark results on a Ryzen 7 2700X:
master
(with extra benchmarks)memcmp-x86_64
builtin
Note that the results may vary a lot, e.g.
memcmp_rust_unaligned_1048575
can be as slow as26933 MB/s
at times.I also added some extra tests though I don't think there are enough yet. I am not sure what edge cases should be considered though.