Skip to content

Add ppc_alias to the intrinsics! macro #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/float/add.rs
Original file line number Diff line number Diff line change
Expand Up @@ -203,16 +203,12 @@ intrinsics! {
add(a, b)
}

#[cfg(not(any(feature = "no-f16-f128", target_arch = "powerpc", target_arch = "powerpc64")))]
#[ppc_alias = __addkf3]
#[cfg(not(feature = "no-f16-f128"))]
pub extern "C" fn __addtf3(a: f128, b: f128) -> f128 {
add(a, b)
}

#[cfg(all(not(feature = "no-f16-f128"), any(target_arch = "powerpc", target_arch = "powerpc64")))]
pub extern "C" fn __addkf3(a: f128, b: f128) -> f128 {
add(a, b)
}

#[cfg(target_arch = "arm")]
pub extern "C" fn __addsf3vfp(a: f32, b: f32) -> f32 {
a + b
Expand Down
54 changes: 8 additions & 46 deletions src/float/cmp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -172,89 +172,51 @@ intrinsics! {
}
}

#[cfg(not(any(
feature = "no-f16-f128",
target_arch = "powerpc",
target_arch = "powerpc64"
)))]
#[cfg(not(feature = "no-f16-f128",))]
intrinsics! {
#[avr_skip]
#[ppc_alias = __lekf2]
pub extern "C" fn __letf2(a: f128, b: f128) -> i32 {
cmp(a, b).to_le_abi()
}

#[avr_skip]
#[ppc_alias = __gekf2]
pub extern "C" fn __getf2(a: f128, b: f128) -> i32 {
cmp(a, b).to_ge_abi()
}

#[avr_skip]
#[ppc_alias = __unordkf2]
pub extern "C" fn __unordtf2(a: f128, b: f128) -> i32 {
unord(a, b) as i32
}

#[avr_skip]
#[ppc_alias = __eqkf2]
pub extern "C" fn __eqtf2(a: f128, b: f128) -> i32 {
cmp(a, b).to_le_abi()
}

#[avr_skip]
#[ppc_alias = __ltkf2]
pub extern "C" fn __lttf2(a: f128, b: f128) -> i32 {
cmp(a, b).to_le_abi()
}

#[avr_skip]
#[ppc_alias = __nekf2]
pub extern "C" fn __netf2(a: f128, b: f128) -> i32 {
cmp(a, b).to_le_abi()
}

#[avr_skip]
#[ppc_alias = __gtkf2]
pub extern "C" fn __gttf2(a: f128, b: f128) -> i32 {
cmp(a, b).to_ge_abi()
}
}

#[cfg(all(
not(feature = "no-f16-f128"),
any(target_arch = "powerpc", target_arch = "powerpc64")
))]
intrinsics! {
#[avr_skip]
pub extern "C" fn __lekf2(a: f128, b: f128) -> i32 {
cmp(a, b).to_le_abi()
}

#[avr_skip]
pub extern "C" fn __gekf2(a: f128, b: f128) -> i32 {
cmp(a, b).to_ge_abi()
}

#[avr_skip]
pub extern "C" fn __unordkf2(a: f128, b: f128) -> i32 {
unord(a, b) as i32
}

#[avr_skip]
pub extern "C" fn __eqkf2(a: f128, b: f128) -> i32 {
cmp(a, b).to_le_abi()
}

#[avr_skip]
pub extern "C" fn __ltkf2(a: f128, b: f128) -> i32 {
cmp(a, b).to_le_abi()
}

#[avr_skip]
pub extern "C" fn __nekf2(a: f128, b: f128) -> i32 {
cmp(a, b).to_le_abi()
}

#[avr_skip]
pub extern "C" fn __gtkf2(a: f128, b: f128) -> i32 {
cmp(a, b).to_ge_abi()
}
}

#[cfg(target_arch = "arm")]
intrinsics! {
pub extern "aapcs" fn __aeabi_fcmple(a: f32, b: f32) -> i32 {
Expand Down
6 changes: 6 additions & 0 deletions src/float/conv.rs
Original file line number Diff line number Diff line change
Expand Up @@ -262,16 +262,19 @@ intrinsics! {
float_to_unsigned_int(f)
}

#[ppc_alias = __fixunskfsi]
#[cfg(not(feature = "no-f16-f128"))]
pub extern "C" fn __fixunstfsi(f: f128) -> u32 {
float_to_unsigned_int(f)
}

#[ppc_alias = __fixunskfdi]
#[cfg(not(feature = "no-f16-f128"))]
pub extern "C" fn __fixunstfdi(f: f128) -> u64 {
float_to_unsigned_int(f)
}

#[ppc_alias = __fixunskfti]
#[cfg(not(feature = "no-f16-f128"))]
pub extern "C" fn __fixunstfti(f: f128) -> u128 {
float_to_unsigned_int(f)
Expand Down Expand Up @@ -310,16 +313,19 @@ intrinsics! {
float_to_signed_int(f)
}

#[ppc_alias = __fixkfsi]
#[cfg(not(feature = "no-f16-f128"))]
pub extern "C" fn __fixtfsi(f: f128) -> i32 {
float_to_signed_int(f)
}

#[ppc_alias = __fixkfdi]
#[cfg(not(feature = "no-f16-f128"))]
pub extern "C" fn __fixtfdi(f: f128) -> i64 {
float_to_signed_int(f)
}

#[ppc_alias = __fixkfti]
#[cfg(not(feature = "no-f16-f128"))]
pub extern "C" fn __fixtfti(f: f128) -> i128 {
float_to_signed_int(f)
Expand Down
21 changes: 3 additions & 18 deletions src/float/extend.rs
Original file line number Diff line number Diff line change
Expand Up @@ -100,37 +100,22 @@ intrinsics! {

#[avr_skip]
#[aapcs_on_arm]
#[cfg(not(any(target_arch = "powerpc", target_arch = "powerpc64")))]
#[ppc_alias = __extendhfkf2]
pub extern "C" fn __extendhftf2(a: f16) -> f128 {
extend(a)
}

#[cfg(any(target_arch = "powerpc", target_arch = "powerpc64"))]
pub extern "C" fn __extendhfkf2(a: f16) -> f128 {
extend(a)
}

#[avr_skip]
#[aapcs_on_arm]
#[cfg(not(any(target_arch = "powerpc", target_arch = "powerpc64")))]
#[ppc_alias = __extendsfkf2]
pub extern "C" fn __extendsftf2(a: f32) -> f128 {
extend(a)
}

#[cfg(any(target_arch = "powerpc", target_arch = "powerpc64"))]
pub extern "C" fn __extendsfkf2(a: f32) -> f128 {
extend(a)
}

#[avr_skip]
#[aapcs_on_arm]
#[cfg(not(any(target_arch = "powerpc", target_arch = "powerpc64")))]
#[ppc_alias = __extenddfkf2]
pub extern "C" fn __extenddftf2(a: f64) -> f128 {
extend(a)
}

#[cfg(any(target_arch = "powerpc", target_arch = "powerpc64"))]
pub extern "C" fn __extenddfkf2(a: f64) -> f128 {
extend(a)
}
}
9 changes: 2 additions & 7 deletions src/float/mul.rs
Original file line number Diff line number Diff line change
Expand Up @@ -199,17 +199,12 @@ intrinsics! {
mul(a, b)
}

#[cfg(not(any(feature = "no-f16-f128", target_arch = "powerpc", target_arch = "powerpc64")))]
#[ppc_alias = __mulkf3]
#[cfg(not(feature = "no-f16-f128"))]
pub extern "C" fn __multf3(a: f128, b: f128) -> f128 {
mul(a, b)
}


#[cfg(all(not(feature = "no-f16-f128"), any(target_arch = "powerpc", target_arch = "powerpc64")))]
pub extern "C" fn __mulkf3(a: f128, b: f128) -> f128 {
mul(a, b)
}

#[cfg(target_arch = "arm")]
pub extern "C" fn __mulsf3vfp(a: f32, b: f32) -> f32 {
a * b
Expand Down
13 changes: 6 additions & 7 deletions src/float/sub.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,15 @@ intrinsics! {
__adddf3(a, f64::from_repr(b.repr() ^ f64::SIGN_MASK))
}

#[cfg(not(any(feature = "no-f16-f128", target_arch = "powerpc", target_arch = "powerpc64")))]
#[ppc_alias = __subkf3]
#[cfg(not(feature = "no-f16-f128"))]
pub extern "C" fn __subtf3(a: f128, b: f128) -> f128 {
#[cfg(any(target_arch = "powerpc", target_arch = "powerpc64"))]
use crate::float::add::__addkf3 as __addtf3;
#[cfg(not(any(target_arch = "powerpc", target_arch = "powerpc64")))]
use crate::float::add::__addtf3;
__addtf3(a, f128::from_repr(b.repr() ^ f128::SIGN_MASK))
}

#[cfg(all(not(feature = "no-f16-f128"), any(target_arch = "powerpc", target_arch = "powerpc64")))]
pub extern "C" fn __subkf3(a: f128, b: f128) -> f128 {
use crate::float::add::__addkf3;
__addkf3(a, f128::from_repr(b.repr() ^ f128::SIGN_MASK))
__addtf3(a, f128::from_repr(b.repr() ^ f128::SIGN_MASK))
}

#[cfg(target_arch = "arm")]
Expand Down
21 changes: 3 additions & 18 deletions src/float/trunc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -155,37 +155,22 @@ intrinsics! {

#[avr_skip]
#[aapcs_on_arm]
#[cfg(not(any(target_arch = "powerpc", target_arch = "powerpc64")))]
#[ppc_alias = __trunckfhf2]
pub extern "C" fn __trunctfhf2(a: f128) -> f16 {
trunc(a)
}

#[cfg(any(target_arch = "powerpc", target_arch = "powerpc64"))]
pub extern "C" fn __trunckfhf2(a: f128) -> f16 {
trunc(a)
}

#[avr_skip]
#[aapcs_on_arm]
#[cfg(not(any(target_arch = "powerpc", target_arch = "powerpc64")))]
#[ppc_alias = __trunckfsf2]
pub extern "C" fn __trunctfsf2(a: f128) -> f32 {
trunc(a)
}

#[cfg(any(target_arch = "powerpc", target_arch = "powerpc64"))]
pub extern "C" fn __trunckfsf2(a: f128) -> f32 {
trunc(a)
}

#[avr_skip]
#[aapcs_on_arm]
#[cfg(not(any(target_arch = "powerpc", target_arch = "powerpc64")))]
#[ppc_alias = __trunckfdf2]
pub extern "C" fn __trunctfdf2(a: f128) -> f64 {
trunc(a)
}

#[cfg(any(target_arch = "powerpc", target_arch = "powerpc64"))]
pub extern "C" fn __trunckfdf2(a: f128) -> f64 {
trunc(a)
}
}
33 changes: 33 additions & 0 deletions src/macros.rs
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ macro_rules! public_test_dep {
/// it's a normal ABI elsewhere for returning a 128 bit integer.
/// * `arm_aeabi_alias` - handles the "aliasing" of various intrinsics on ARM
/// their otherwise typical names to other prefixed ones.
/// * `ppc_alias` - changes the name of the symbol on PowerPC platforms without
/// changing any other behavior. This is mostly for `f128`, which is `tf` on
/// most platforms but `kf` on PowerPC.
macro_rules! intrinsics {
() => ();

Expand Down Expand Up @@ -320,6 +323,36 @@ macro_rules! intrinsics {
intrinsics!($($rest)*);
);

// PowerPC usually uses `kf` rather than `tf` for `f128`. This is just an easy
// way to add an alias on those targets.
(
#[ppc_alias = $alias:ident]
$(#[$($attr:tt)*])*
pub extern $abi:tt fn $name:ident( $($argname:ident: $ty:ty),* ) $(-> $ret:ty)? {
$($body:tt)*
}

$($rest:tt)*
) => (
#[cfg(not(any(target_arch = "powerpc", target_arch = "powerpc64")))]
intrinsics! {
$(#[$($attr)*])*
pub extern $abi fn $name( $($argname: $ty),* ) $(-> $ret)? {
$($body)*
}
}

#[cfg(any(target_arch = "powerpc", target_arch = "powerpc64"))]
intrinsics! {
$(#[$($attr)*])*
pub extern $abi fn $alias( $($argname: $ty),* ) $(-> $ret)? {
$($body)*
}
}

intrinsics!($($rest)*);
);

// C mem* functions are only generated when the "mem" feature is enabled.
(
#[mem_builtin]
Expand Down
7 changes: 7 additions & 0 deletions testcrate/tests/conv.rs
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,13 @@ mod f_to_i {
#[test]
#[cfg(not(feature = "no-f16-f128"))]
fn f128_to_int() {
#[cfg(any(target_arch = "powerpc", target_arch = "powerpc64"))]
use compiler_builtins::float::conv::{
__fixkfdi as __fixtfdi, __fixkfsi as __fixtfsi, __fixkfti as __fixtfti,
__fixunskfdi as __fixunstfdi, __fixunskfsi as __fixunstfsi,
__fixunskfti as __fixunstfti,
};
#[cfg(not(any(target_arch = "powerpc", target_arch = "powerpc64")))]
use compiler_builtins::float::conv::{
__fixtfdi, __fixtfsi, __fixtfti, __fixunstfdi, __fixunstfsi, __fixunstfti,
};
Expand Down