-
Notifications
You must be signed in to change notification settings - Fork 17
Link to skill tree and fix some nodes #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -84,8 +84,7 @@ href = "https://github.com/rust-lang/const-eval/issues/14" | |||
|
|||
[[group]] | |||
name = "offset_of" | |||
label = "offset_of\nfeature:const_ptr_offset" | |||
href = "https://github.com/rust-lang/rust/issues/71499" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
offset_of
has very little to do with offset
/wrapping_offset
. If we want the latter in the skill tree, they should be a separate node. EDIT: done that.
@@ -179,10 +184,9 @@ href = "https://github.com/rust-lang/rust/issues/74925" | |||
items = [] | |||
|
|||
[[group]] | |||
name = "rfc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this used to contain more RFCs, but they have been moved to tracking issues since. I was thinking that we should somehow highlight that some node is an RFC and not something already accepted (though... considering the random collection of issues I opened that doesn't have a merged RFC, I guess we can just treat them the same)
Hm, https://rust-lang.github.io/const-eval/ still contains that "rfc" node? |
CI said
|
I did a direct push to hopefully fix this. |
r? @oli-obk
Fixes #51