Skip to content

Link to skill tree and fix some nodes #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 10, 2020
Merged

Conversation

RalfJung
Copy link
Member

r? @oli-obk
Fixes #51

@RalfJung RalfJung changed the title Link to skill tree and change const-blocks node Link to skill tree and fix some nodes Aug 10, 2020
@@ -84,8 +84,7 @@ href = "https://github.com/rust-lang/const-eval/issues/14"

[[group]]
name = "offset_of"
label = "offset_of\nfeature:const_ptr_offset"
href = "https://github.com/rust-lang/rust/issues/71499"
Copy link
Member Author

@RalfJung RalfJung Aug 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

offset_of has very little to do with offset/wrapping_offset. If we want the latter in the skill tree, they should be a separate node. EDIT: done that.

@@ -179,10 +184,9 @@ href = "https://github.com/rust-lang/rust/issues/74925"
items = []

[[group]]
name = "rfc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this used to contain more RFCs, but they have been moved to tracking issues since. I was thinking that we should somehow highlight that some node is an RFC and not something already accepted (though... considering the random collection of issues I opened that doesn't have a merged RFC, I guess we can just treat them the same)

@oli-obk oli-obk merged commit d4fd617 into rust-lang:master Aug 10, 2020
@RalfJung
Copy link
Member Author

Hm, https://rust-lang.github.io/const-eval/ still contains that "rfc" node?

@RalfJung RalfJung deleted the skills branch August 10, 2020 19:02
@RalfJung
Copy link
Member Author

CI said

Warning: The mdbook-skill-tree preprocessor was built against version 0.3.7 of mdbook, but we're being called from version 0.4.1
thread 'main' panicked at 'encountered error missing field `items` for key `group` at line 279 column 1', mdbook-skill-tree/src/preprocessor.rs:85:31
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-08-10 13:22:09 [ERROR] (mdbook::utils): Error: The preprocessor exited unsuccessfully
##[error]Process completed with exit code 101.

@RalfJung
Copy link
Member Author

I did a direct push to hopefully fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to skill tree
2 participants