Skip to content

Update ptr::copy_nonoverlapping #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Conversation

usbalbin
Copy link
Contributor

@usbalbin usbalbin commented Jan 4, 2021

Update ptr::copy_nonoverlapping with feature gate and link to tracking issue.

@usbalbin
Copy link
Contributor Author

usbalbin commented Jan 4, 2021

I have not quite figured out how to compile, I am currently getting

$ mdbook build
2021-01-04 19:57:22 [INFO] (mdbook::book): Book building has started
Warning: The mdbook-mermaid preprocessor was built against version 0.3.7 of mdbook, but we're being called from version 0.4.4
2021-01-04 19:57:22 [INFO] (mdbook::book): Running the html backend
2021-01-04 19:57:22 [ERROR] (mdbook::utils): Error: Rendering failed
2021-01-04 19:57:22 [ERROR] (mdbook::utils):    Caused By: Unable to copy across additional CSS and JS
2021-01-04 19:57:22 [ERROR] (mdbook::utils):    Caused By: Unable to copy /home/albin/rust/const-eval/skill-tree.css to /home/albin/rust/const-eval/book/skill-tree.css
2021-01-04 19:57:22 [ERROR] (mdbook::utils):    Caused By: No such file or directory (os error 2)

so my changes are not tested at all(!)

@oli-obk
Copy link
Contributor

oli-obk commented Jan 4, 2021

Heh, yea, that failure is because the skill tree mdbook thing needs some initial setup. We haven't really documented anything, but in CI this is

run: mdbook-skill-tree install
(you need to install that command first)

@oli-obk oli-obk marked this pull request as ready for review January 4, 2021 19:11
@oli-obk
Copy link
Contributor

oli-obk commented Jan 4, 2021

The change lgtm tho, so let's just make this CI's job so you don't have to install anything

@oli-obk oli-obk merged commit 07328a7 into rust-lang:master Jan 4, 2021
@usbalbin
Copy link
Contributor Author

usbalbin commented Jan 4, 2021

Ok, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants