Skip to content

Commit 0db37c8

Browse files
committed
crate.version: Convert loadReadme() to ember-concurrency task
1 parent 44472fc commit 0db37c8

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

app/controllers/crate/version.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import PromiseProxyMixin from '@ember/object/promise-proxy-mixin';
55
import ArrayProxy from '@ember/array/proxy';
66
import { computed } from '@ember/object';
77
import moment from 'moment';
8+
import { task } from 'ember-concurrency';
89

910
const NUM_VERSIONS = 5;
1011

@@ -156,12 +157,12 @@ export default Controller.extend({
156157
return data;
157158
}),
158159

159-
async loadReadme() {
160+
loadReadmeTask: task(function* () {
160161
if (this.currentVersion.get('readme_path')) {
161162
try {
162-
let r = await fetch(this.currentVersion.get('readme_path'));
163+
let r = yield fetch(this.currentVersion.get('readme_path'));
163164
if (r.ok) {
164-
this.crate.set('readme', await r.text());
165+
this.crate.set('readme', yield r.text());
165166

166167
if (typeof document !== 'undefined') {
167168
setTimeout(() => {
@@ -177,5 +178,5 @@ export default Controller.extend({
177178
this.crate.set('readme', null);
178179
}
179180
}
180-
},
181+
}),
181182
});

app/routes/crate/version.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export default Route.extend({
9696

9797
setupController(controller) {
9898
this._super(...arguments);
99-
controller.loadReadme();
99+
controller.loadReadmeTask.perform();
100100
},
101101

102102
serialize(model) {

0 commit comments

Comments
 (0)