Merge #1143

1143: #1117 UI for managing crate ownership r=carols10cents

Created a separate page for this rather than start tacking on a bunch of modals #1117

Author: bors-voyager[bot]

app/adapters/crate.js

@@ -5,11 +5,31 @@ export default ApplicationAdapter.extend({
         return this.ajax(this.urlForFollowAction(id), 'PUT');
     },
 
+    inviteOwner(id, username) {
+        return this.ajax(this.urlForOwnerAction(id), 'PUT', {
+            data: {
+                owners: [username],
+            }
+        });
+    },
+
+    removeOwner(id, username) {
+        return this.ajax(this.urlForOwnerAction(id), 'DELETE', {
+            data: {
+                owners: [username],
+            }
+        });
+    },
+
     unfollow(id) {
         return this.ajax(this.urlForFollowAction(id), 'DELETE');
     },
 
     urlForFollowAction(id) {
         return `${this.buildURL('crate', id)}/follow`;
     },
+
+    urlForOwnerAction(id) {
+        return `${this.buildURL('crate', id)}/owners`;
+    }
 });

app/controllers/crate/owners.js

@@ -0,0 +1,55 @@
+import Controller, { inject as controller } from '@ember/controller';
+import { computed } from '@ember/object';
+
+export default Controller.extend({
+    crateController: controller('crate'),
+    crate: computed.alias('crateController.model'),
+    error: false,
+    invited: false,
+    removed: false,
+    username: '',
+
+    actions: {
+        addOwner() {
+            this.set('error', false);
+            this.set('invited', false);
+
+            const username = this.get('username');
+
+            if (!username) {
+                this.set('error', 'Please enter a username');
+                return false;
+            }
+
+            return this.get('crate').inviteOwner(username).then(() => {
+                this.set('invited', `An invite has been sent to ${username}`);
+            }).catch((error) => {
+                if (error.payload) {
+                    this.set('error',
+                        `Error sending invite: ${error.payload.errors[0].detail}`
+                    );
+                } else {
+                    this.set('error', 'Error sending invite');
+                }
+            });
+        },
+
+        removeOwner(user) {
+            this.set('removed', false);
+
+            return this.get('crate').removeOwner(user.get('login')).then(() => {
+                this.set('removed', `User ${user.get('login')} removed as crate owner`);
+
+                this.get('crate.owner_user').removeObject(user);
+            }).catch((error) => {
+                if (error.payload) {
+                    this.set('removed',
+                        `Error removing owner: ${error.payload.errors[0].detail}`
+                    );
+                } else {
+                    this.set('removed', 'Error removing owner');
+                }
+            });
+        }
+    }
+});

app/controllers/crate/version.js

@@ -26,6 +26,9 @@ export default Controller.extend({
     keywords: computed.alias('crate.keywords'),
     categories: computed.alias('crate.categories'),
     badges: computed.alias('crate.badges'),
+    isOwner: computed('crate.owner_user', function() {
+        return this.get('crate.owner_user').findBy('login', this.session.get('currentUser.login'));
+    }),
 
     sortedVersions: computed.readOnly('crate.versions'),
 

app/models/crate.js

@@ -38,6 +38,14 @@ export default DS.Model.extend({
         return this.store.adapterFor('crate').follow(this.get('id'));
     },
 
+    inviteOwner(username) {
+        return this.store.adapterFor('crate').inviteOwner(this.get('id'), username);
+    },
+
+    removeOwner(username) {
+        return this.store.adapterFor('crate').removeOwner(this.get('id'), username);
+    },
+
     unfollow() {
         return this.store.adapterFor('crate').unfollow(this.get('id'));
     },

app/router.js

@@ -21,6 +21,8 @@ Router.map(function() {
 
         this.route('reverse_dependencies');
 
+        this.route('owners');
+
         // Well-known routes
         this.route('docs');
         this.route('repo');

app/templates/crate/owners.hbs

@@ -0,0 +1,68 @@
+{{ title 'Manage Crate Owners' }}
+
+<div id='crates-heading'>
+    {{svg-jar "gear"}}
+    <h1>Manage Crate Owners</h1>
+    <h2>{{ crate.name }}</h2>
+</div>
+
+<div id="me-email">
+    <h2>Add Owner</h2>
+
+    <div class="row">
+        <div class="label">
+            <dt>Username</dt>
+        </div>
+
+        <form class="email-form" {{action 'addOwner' on='submit'}}>
+            {{input type='text' value=username placeholder='Username' class='form-control space-right' name='username'}}
+
+            {{#if error}}
+                <div class='error'>
+                    <p class='small-text error'>{{error}}</p>
+                </div>
+            {{/if}}
+
+            {{#if invited}}
+                <div class='invited'>
+                    <p>{{invited}}</p>
+                </div>
+            {{/if}}
+
+            <div class="actions">
+                <button id="add-owner" type="submit" class="small yellow-button space-right">Save</button>
+            </div>
+        </form>
+    </div>
+</div>
+
+<h2>Owners</h2>
+
+{{#if removed}}
+<div class='removed'>
+    <p>{{removed}}</p>
+</div>
+{{/if}}
+
+<div class='owners white-rows'>
+    {{#each crate.owner_user as |user|}}
+        <div class='crate row'>
+            <div>
+                {{#link-to user.kind user.login}}
+                    {{user-avatar user=user size='medium-small'}}
+                {{/link-to}}
+            </div>
+            <div>
+                {{#link-to user.kind user.login}}
+                    {{ user.name }}
+                {{/link-to}}
+            </div>
+            <div class='stats'>
+                {{{ if user.email user.email "&nbsp;" }}}
+            </div>
+            <div class='stats downloads'>
+                <button class='remove-owner small yellow-button' {{action 'removeOwner' user}}>Remove</button>
+            </div>
+        </div>
+    {{/each}}
+</div>

app/templates/crate/version.hbs

@@ -167,8 +167,17 @@
                 {{/if}}
             {{/unless}}
 
-            <div>
+            <div id='crate-owners'>
                 <h3>Owners</h3>
+
+                {{#if isOwner}}
+                <p>
+                    {{#link-to 'crate.owners' crate}}
+                        Manage owners
+                    {{/link-to}}
+                </p>
+                {{/if}}
+
                 <ul class='owners' data-test-owners>
                    {{#each crate.owner_team as |team|}}
                         <li>

mirage/config.js

@@ -206,6 +206,44 @@ export default function() {
         let user = schema.users.findBy({ login });
         return user ? user : notFound();
     });
+
+    this.put('/crates/:crate_id/owners', (schema, request) => {
+        const crateId = request.params.crate_id;
+        const crate = schema.crates.find(crateId);
+
+        if (!crate) {
+            return notFound();
+        }
+
+        const body = JSON.parse(request.requestBody);
+        const [ownerId] = body.owners;
+        const user = schema.users.findBy({ login: ownerId });
+
+        if (!user) {
+            return notFound();
+        }
+
+        return { ok: true };
+    });
+
+    this.delete('/crates/:crate_id/owners', (schema, request) => {
+        const crateId = request.params.crate_id;
+        const crate = schema.crates.find(crateId);
+
+        if (!crate) {
+            return notFound();
+        }
+
+        const body = JSON.parse(request.requestBody);
+        const [ownerId] = body.owners;
+        const user = schema.users.findBy({ login: ownerId });
+
+        if (!user) {
+            return notFound();
+        }
+
+        return {};
+    });
 }
 
 function notFound() {

mirage/fixtures/users.js

@@ -13,4 +13,11 @@ export default [{
     "login": "thehydroimpulse",
     "name": "Daniel Fagnan",
     "url": "https://github.com/thehydroimpulse"
+}, {
+    "avatar": "https://avatars3.githubusercontent.com/u/1179195?v=3",
+    "email": "[email protected]",
+    "id": 10982,
+    "login": "iain8",
+    "name": "Iain Buchanan",
+    "url": "https://github.com/iain8"
 }];

tests/acceptance/crate-test.js

@@ -1,6 +1,7 @@
 import { test } from 'qunit';
-import { click, visit, currentURL, currentRouteName } from 'ember-native-dom-helpers';
+import { click, visit, currentURL, currentRouteName, fillIn } from 'ember-native-dom-helpers';
 import moduleForAcceptance from 'cargo/tests/helpers/module-for-acceptance';
+import Ember from 'ember';
 
 moduleForAcceptance('Acceptance | crate page');
 
@@ -127,3 +128,99 @@ test('crates license is supplied by version', async function(assert) {
     await click('[data-test-version-link="0.5.0"]');
     assert.dom('[data-test-license]').hasText('MIT/Apache-2.0');
 });
+
+test('navigating to the owners page when not logged in', async function(assert) {
+    server.loadFixtures();
+
+    await visit('/crates/nanomsg');
+
+    assert.dom('#crate-owners p a').doesNotExist();
+});
+
+test('navigating to the owners page when not an owner', async function(assert) {
+    server.loadFixtures();
+
+    this.application.register('service:session-b', Ember.Service.extend({
+        currentUser: {
+            login: 'iain8'
+        }
+    }));
+
+    this.application.inject('controller', 'session', 'service:session-b');
+
+    await visit('/crates/nanomsg');
+
+    assert.dom('#crate-owners p a').doesNotExist();
+});
+
+test('navigating to the owners page', async function(assert) {
+    server.loadFixtures();
+
+    this.application.register('service:session-b', Ember.Service.extend({
+        currentUser: {
+            login: 'thehydroimpulse'
+        }
+    }));
+
+    this.application.inject('controller', 'session', 'service:session-b');
+
+    await visit('/crates/nanomsg');
+    await click('#crate-owners p a');
+
+    assert.dom('#crates-heading h1').hasText('Manage Crate Owners');
+});
+
+test('listing crate owners', async function(assert) {
+    server.loadFixtures();
+
+    await visit('/crates/nanomsg/owners');
+
+    assert.dom('.owners .row').exists({ count: 2 });
+    assert.dom('a[href="/users/thehydroimpulse"]').exists();
+    assert.dom('a[href="/users/blabaere"]').exists();
+});
+
+test('attempting to add owner without username', async function(assert) {
+    server.loadFixtures();
+
+    await visit('/crates/nanomsg/owners');
+    await click('#add-owner');
+
+    assert.dom('.error').exists();
+    assert.dom('.error').hasText('Please enter a username');
+    assert.dom('.owners .row').exists({ count: 2 });
+});
+
+test('attempting to add non-existent owner', async function(assert) {
+    server.loadFixtures();
+
+    await visit('/crates/nanomsg/owners');
+    await fillIn('input[name="username"]', 'spookyghostboo');
+    await click('#add-owner');
+
+    assert.dom('.error').exists();
+    assert.dom('.error').hasText('Error sending invite');
+    assert.dom('.owners .row').exists({ count: 2 });
+});
+
+test('add a new owner', async function(assert) {
+    server.loadFixtures();
+
+    await visit('/crates/nanomsg/owners');
+    await fillIn('input[name="username"]', 'iain8');
+    await click('#add-owner');
+
+    assert.dom('.invited').exists();
+    assert.dom('.invited').hasText('An invite has been sent to iain8');
+    assert.dom('.owners .row').exists({ count: 2 });
+});
+
+test('remove a crate owner', async function(assert) {
+    server.loadFixtures();
+
+    await visit('/crates/nanomsg/owners');
+    await click('.owners .row:first-child .remove-owner');
+
+    assert.dom('.removed').exists();
+    assert.dom('.owners .row').exists({ count: 1 });
+});