UI for managing crate ownership #1143
Conversation
iain8
changed the title
The "manage owners" link wasn't showing up for me even when I was an owner because it couldn't match up logins and database ids :)
carols10cents
force-pushed
the
add-remove-owner-ui
branch
from
2fc8cbe to
351c703
Compare
There was a problem hiding this comment.
This looks awesome, sorry it took me so long to review!!
I noticed a tiny problem, the link to manage owners wasn't showing up for me-- turns out currentUser.id is the database id, so switching it to currentUser.login made everything work the way I expected :)
There were also some ember test changes in upstream; just needed to import fillIn.
I'm going to wait for travis to go green then merge this :) thanks!!
tests/acceptance/crate-test.js
Outdated
| } | ||
| })); | ||
|
|
||
| this.application.inject('controller', 'session', 'service:session-b'); |
There was a problem hiding this comment.
OMG COOL THIS IS HOW TO FAKE LOGGING IN IN THE JAVASCRIPT TESTS!! I tried to figure this out for a long time and couldn't!!!
There was a problem hiding this comment.
yes! 😄 it is very unclear in the documentation that you have to do this and can't use an existing service.
|
bors: r+ |
Build succeeded |
Created a separate page for this rather than start tacking on a bunch of modals #1117