Skip to content

Commit 32d93b4

Browse files
committed
Auto merge of #4148 - Turbo87:node, r=locks
Pin Node.js version We currently use one Node.js version in production, another on CI and yet another one for our Docker setup. This PR pins them all to the same release (latest v14.x) and configures renovatebot to automatically keep the versions updated.
2 parents 132139d + 6184c96 commit 32d93b4

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

.github/renovate.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,13 @@
1818
"labels": ["A-backend"]
1919
},
2020
"regexManagers": [
21+
{
22+
"fileMatch": ["^.github/workflows/[^\\.]+\\.ya?ml$"],
23+
"matchStrings": ["NODE_VERSION:\\s*(?<currentValue>.*?)\n"],
24+
"depNameTemplate": "node",
25+
"datasourceTemplate": "github-releases",
26+
"lookupNameTemplate": "nodejs/node"
27+
},
2128
{
2229
"fileMatch": ["^.github/workflows/[^\\.]+\\.ya?ml$"],
2330
"matchStrings": ["RUST_VERSION:\\s*(?<currentValue>.*?)\n"],

.github/workflows/ci.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ on:
1010
pull_request:
1111

1212
env:
13+
NODE_VERSION: 14.18.1
1314
RUST_VERSION: 1.56.1
1415

1516
jobs:
@@ -29,7 +30,7 @@ jobs:
2930

3031
- uses: actions/setup-node@v2
3132
with:
32-
node-version: '14.x'
33+
node-version: ${{ env.NODE_VERSION }}
3334

3435
- name: Install node modules
3536
run: yarn install
@@ -59,7 +60,7 @@ jobs:
5960

6061
- uses: actions/setup-node@v2
6162
with:
62-
node-version: '14.x'
63+
node-version: ${{ env.NODE_VERSION }}
6364

6465
- run: yarn install
6566

frontend.Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:16.12-alpine
1+
FROM node:14.18.1-alpine
22

33
WORKDIR /app
44
COPY package.json yarn.lock /app/

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@
135135
"ember-modifier": "3.0.0"
136136
},
137137
"engines": {
138-
"node": "^14.9.0",
138+
"node": "14.18.1",
139139
"npm": "^8.0.0"
140140
},
141141
"ember": {

0 commit comments

Comments
 (0)