Pin Node.js version #4148
Merged
Pin Node.js version #4148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to what is being used in production
Turbo87
added
A-frontend 🐹
C-internal 🔧
|
Pretty good 💪 Shouldn't CI pick up the version from |
|
@bors r+ |
|
📌 Commit 6184c96 has been approved by |
not that I'm aware of 🤔 |
|
I may be confusing it with the volta GitHub Action 🤔 |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Nov 9, 2021
renovate: Adjust `node` package grouping #4148 introduced a new way for renovatebot to update our Node.js version, but it wasn't perfectly compatible with the others yet. This PR fixes the issue, and unifies how renovatebot updates the Node.js versions in all of the relevant files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use one Node.js version in production, another on CI and yet another one for our Docker setup. This PR pins them all to the same release (latest v14.x) and configures renovatebot to automatically keep the versions updated.