Bump clippy to latest nightly

Author: jtgeibel

.travis.yml

@@ -51,7 +51,7 @@ matrix:
     - cargo build
     - cargo test
     - npm test
-  - rust: nightly-2017-09-20
+  - rust: nightly-2017-11-07
     env: CLIPPY=YESPLEASE
     script:
     - cargo check --features "lint"

Cargo.lock

@@ -53,7 +53,7 @@ diesel_full_text_search = "0.16.0"
 serde_json = "1.0.0"
 serde_derive = "1.0.0"
 serde = "1.0.0"
-clippy = { version = "=0.0.162", optional = true }
+clippy = { version = "=0.0.169", optional = true }
 chrono = { version = "0.4.0", features = ["serde"] }
 comrak = { version = "0.2.3", default-features = false }
 ammonia = { git = "https://github.com/notriddle/ammonia", rev = "3d4e4073f8cdb7c60203b9036c09f4385a2fdbbd" }

Cargo.toml

@@ -1,3 +1,4 @@
+#[allow(unused_imports)] // TODO: Remove when rustc 1.23 is stable
 use std::ascii::AsciiExt;
 
 use chrono::NaiveDateTime;

src/keyword.rs

@@ -41,7 +41,7 @@ pub fn summary(req: &mut Request) -> CargoResult<Response> {
             .map(|versions| Version::max(versions.into_iter().map(|v| v.num)))
             .zip(krates)
             .map(|(max_version, krate)| {
-                Ok(krate.minimal_encodable(max_version, None, false, None))
+                Ok(krate.minimal_encodable(&max_version, None, false, None))
             })
             .collect()
     };
@@ -153,7 +153,7 @@ pub fn show(req: &mut Request) -> CargoResult<Response> {
     Ok(
         req.json(&R {
             krate: krate.clone().encodable(
-                max_version,
+                &max_version,
                 Some(ids),
                 Some(&kws),
                 Some(&cats),

src/krate/metadata.rs

@@ -1,3 +1,4 @@
+#[allow(unused_imports)] // TODO: Remove when rustc 1.23 is stable
 use std::ascii::AsciiExt;
 
 use chrono::{NaiveDate, NaiveDateTime};
@@ -26,7 +27,7 @@ pub mod metadata;
 
 /// Hosts in this blacklist are known to not be hosting documentation,
 /// and are possibly of malicious intent e.g. ad tracking networks, etc.
-const DOCUMENTATION_BLACKLIST: [&'static str; 1] = ["rust-ci.org"];
+const DOCUMENTATION_BLACKLIST: [&str; 1] = ["rust-ci.org"];
 
 #[derive(Debug, Insertable, Queryable, Identifiable, Associations, AsChangeset, Clone, Copy)]
 #[belongs_to(Crate)]
@@ -315,7 +316,7 @@ impl Crate {
 
     pub fn minimal_encodable(
         self,
-        max_version: semver::Version,
+        max_version: &semver::Version,
         badges: Option<Vec<Badge>>,
         exact_match: bool,
         recent_downloads: Option<i64>,
@@ -334,7 +335,7 @@ impl Crate {
     #[cfg_attr(feature = "clippy", allow(too_many_arguments))]
     pub fn encodable(
         self,
-        max_version: semver::Version,
+        max_version: &semver::Version,
         versions: Option<Vec<i32>>,
         keywords: Option<&[Keyword]>,
         categories: Option<&[Category]>,

src/krate/mod.rs

@@ -181,7 +181,7 @@ pub fn publish(req: &mut Request) -> CargoResult<Response> {
             warnings: Warnings<'a>,
         }
         Ok(req.json(&R {
-            krate: krate.minimal_encodable(max_version, None, false, None),
+            krate: krate.minimal_encodable(&max_version, None, false, None),
             warnings: warnings,
         }))
     })

src/krate/publish.rs

@@ -201,7 +201,7 @@ pub fn search(req: &mut Request) -> CargoResult<Response> {
                     .filter(badges::crate_id.eq(krate.id))
                     .load::<Badge>(&*conn)?;
                 Ok(krate.minimal_encodable(
-                    max_version,
+                    &max_version,
                     Some(badges),
                     perfect_match,
                     Some(recent_downloads),

src/krate/search.rs

@@ -1,4 +1,4 @@
-//! This crate implements the backend server for https://crates.io/
+//! This crate implements the backend server for <https://crates.io/>
 //!
 //! All implemented routes are defined in the [middleware](fn.middleware.html) function and
 //! implemented in the [category](category/index.html), [keyword](keyword/index.html),

src/lib.rs

@@ -191,7 +191,7 @@ impl Uploader {
     }
 
     /// Deletes an uploaded file.
-    fn delete(&self, app: Arc<App>, path: &str) -> CargoResult<()> {
+    fn delete(&self, app: &Arc<App>, path: &str) -> CargoResult<()> {
         match *self {
             Uploader::S3 { ref bucket, .. } => {
                 let mut handle = app.handle();
@@ -217,7 +217,7 @@ pub struct Bomb {
 impl Drop for Bomb {
     fn drop(&mut self) {
         if let Some(ref path) = self.path {
-            if let Err(e) = self.app.config.uploader.delete(Arc::clone(&self.app), path) {
+            if let Err(e) = self.app.config.uploader.delete(&self.app, path) {
                 println!("unable to delete {}, {:?}", path, e);
             }
         }

src/uploaders.rs

@@ -243,7 +243,7 @@ impl User {
 /// This route will return an authorization URL for the GitHub OAuth flow including the crates.io
 /// `client_id` and a randomly generated `state` secret.
 ///
-/// see https://developer.github.com/v3/oauth/#redirect-users-to-request-github-access
+/// see <https://developer.github.com/v3/oauth/#redirect-users-to-request-github-access>
 ///
 /// ## Response Body Example
 ///
@@ -279,7 +279,7 @@ pub fn github_authorize(req: &mut Request) -> CargoResult<Response> {
 /// to exchange the temporary `code` for an API token. The API token is returned together with
 /// the corresponding user information.
 ///
-/// see https://developer.github.com/v3/oauth/#github-redirects-back-to-your-site
+/// see <https://developer.github.com/v3/oauth/#github-redirects-back-to-your-site>
 ///
 /// ## Query Parameters
 ///

src/user/mod.rs

@@ -342,7 +342,7 @@ pub fn human<S: ToString + ?Sized>(error: &S) -> Box<CargoError> {
 
 /// This is intended to be used for errors being sent back to the Ember
 /// frontend, not to cargo as cargo does not handle non-200 response codes well
-/// (see https://github.com/rust-lang/cargo/issues/3995), but Ember requires
+/// (see <https://github.com/rust-lang/cargo/issues/3995>), but Ember requires
 /// non-200 response codes for its stores to work properly.
 ///
 /// Since this is going back to the UI these errors are treated the same as