Skip to content

Commit 6cb1279

Browse files
committed
Auto merge of #2795 - jtgeibel:hide-yank-button-in-crate-header, r=thiagoarrais
Temporarily remove yank button from crate header Temporarily remove the yank button from the crate page until we find better placement for the button. The buttons added to the all versions page in #2623 remain. I would like to merge this as a temporary fix to unblock deploying to production. I've opened #2794 to track adding this back. r? `@locks` cc `@thiagoarrais`
2 parents de8bdad + 8ace99a commit 6cb1279

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

app/templates/crate/version.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<h1 data-test-crate-name>{{ this.crate.name }}</h1>
88
<h2 data-test-crate-version>{{ this.currentVersion.num }}</h2>
99
{{#if this.isOwner }}
10-
<YankButton @version={{this.currentVersion}} @tan={{true}} />
10+
{{!-- <YankButton @version={{this.currentVersion}} @tan={{true}} /> --}}
1111
{{/if}}
1212
</div>
1313

tests/acceptance/crate-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { click, fillIn, currentURL, currentRouteName, visit, waitFor } from '@ember/test-helpers';
22
import { setupApplicationTest } from 'ember-qunit';
3-
import { module, test } from 'qunit';
3+
import { module, test, skip } from 'qunit';
44

55
import percySnapshot from '@percy/ember';
66
import a11yAudit from 'ember-a11y-testing/test-support/audit';
@@ -219,7 +219,7 @@ module('Acceptance | crate page', function (hooks) {
219219
assert.dom('[data-test-license]').hasText('MIT/Apache-2.0');
220220
});
221221

222-
test('crates can be yanked by owner', async function (assert) {
222+
skip('crates can be yanked by owner', async function (assert) {
223223
this.server.loadFixtures();
224224

225225
let user = this.server.schema.users.findBy({ login: 'thehydroimpulse' });

0 commit comments

Comments
 (0)